[webkit-reviews] review granted: [Bug 193483] StringObjectUse should not be a structure check for the original string object structure : [Attachment 359354] patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <yusukesuzuki at slowstart.org> has granted Saam Barati
<sbarati at apple.com>'s request for review:
Bug 193483: StringObjectUse should not be a structure check for the original
string object structure
https://bugs.webkit.org/show_bug.cgi?id=193483

Attachment 359354: patch

https://bugs.webkit.org/attachment.cgi?id=359354&action=review




--- Comment #3 from Yusuke Suzuki <yusukesuzuki at slowstart.org> ---
Comment on attachment 359354
  --> https://bugs.webkit.org/attachment.cgi?id=359354
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=359354&action=review

r=me with FTL fixes

> Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:6335
> +	       LValue type = m_out.load32(cell, m_heaps.JSCell_typeInfoType);

load8ZeroExt32?

> Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:16068
> +	   LValue type = m_out.load32(cellBase, m_heaps.JSCell_typeInfoType);

Ditto.

> Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:16088
> +	   LValue type = m_out.load32(cell, m_heaps.JSCell_typeInfoType);

Ditto.