[webkit-reviews] review granted: [Bug 193522] (iPad) Link tapping is sluggish on many sites : [Attachment 359340] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Dean Jackson
<dino at apple.com>'s request for review:
Bug 193522: (iPad) Link tapping is sluggish on many sites
https://bugs.webkit.org/show_bug.cgi?id=193522

Attachment 359340: Patch

https://bugs.webkit.org/attachment.cgi?id=359340&action=review




--- Comment #3 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 359340
  --> https://bugs.webkit.org/attachment.cgi?id=359340
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=359340&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:2471
> +    // return !areEssentiallyEqualAsFloat(contentZoomScale(self), 1);

Did you mean to remove this old commented-out line?

>
LayoutTests/fast/events/ios/fast-click-double-tap-sends-click-when-initial-scal
e.html:17
> +	       if (!window.UIHelper)

(Ditto)

>
LayoutTests/fast/events/ios/viewport-zooms-from-element-to-initial-scale.html:1
5
> +	       if (!window.UIHelper)

Nit - doesn't window.UIHelper exist even in the case where the user is manually
testing? It seems like we do want to check either eventSender or runUIScript
(or both).

> LayoutTests/resources/ui-helper.js:57
> +    static zoomByDoubleTapAt(x, y)

Nit - zoomByDoubleTappingAt?