[webkit-reviews] review granted: [Bug 193473] [WebGPU] Update vertex-buffer-triangle-strip.html to actually use vertex buffer : [Attachment 359297] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Justin Fan <justin_fan at apple.com>'s
request for review:
Bug 193473: [WebGPU] Update vertex-buffer-triangle-strip.html to actually use
vertex buffer
https://bugs.webkit.org/show_bug.cgi?id=193473

Attachment 359297: Patch

https://bugs.webkit.org/attachment.cgi?id=359297&action=review




--- Comment #7 from Dean Jackson <dino at apple.com> ---
Comment on attachment 359297
  --> https://bugs.webkit.org/attachment.cgi?id=359297
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=359297&action=review

> Source/WebCore/platform/graphics/gpu/cocoa/GPURenderPipelineMetal.mm:137
> -	   mtlAttributeDesc.bufferIndex = attributes[i].shaderLocation;
> +	   mtlAttributeDesc.bufferIndex = attributes[i].inputSlot;

You don't mention why you made this change. The bug title only mentions the
HTML. What was wrong about it?

> LayoutTests/webgpu/vertex-buffer-triangle-strip.html:17
> +    float4 position [[attribute(0)]];

Can you label with both attribute(0) and position to avoid having two identical
structs?