[webkit-reviews] review granted: [Bug 189097] ASSERTION FAILED: m_networkLoadInformationByID.contains(identifier) in WebKit::NetworkConnectionToWebProcess::addNetworkLoadInformationMetrics : [Attachment 359194] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 189097: ASSERTION FAILED: m_networkLoadInformationByID.contains(identifier)
in WebKit::NetworkConnectionToWebProcess::addNetworkLoadInformationMetrics
https://bugs.webkit.org/show_bug.cgi?id=189097

Attachment 359194: Patch

https://bugs.webkit.org/attachment.cgi?id=359194&action=review




--- Comment #3 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 359194
  --> https://bugs.webkit.org/attachment.cgi?id=359194
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=359194&action=review

> Source/WebKit/NetworkProcess/NetworkResourceLoader.h:116
> +    void shouldNotCaptureExtraNetworkLoadMetricsEnabled() {
m_shouldCaptureExtraNetworkLoadMetrics = false; }

This is a poorly named function.  void
setShouldNotCaptureExtraNetworkLoadMetrics(bool)