[webkit-reviews] review granted: [Bug 193468] Frequent null-deref under TiledCoreAnimationDrawingArea::scaleViewToFitDocumentIfNeeded() : [Attachment 359284] Patch

[bugzilla-daemon at webkit.org]

zalan <zalan at apple.com> has granted Tim Horton <thorton at apple.com>'s request
for review:
Bug 193468: Frequent null-deref under
TiledCoreAnimationDrawingArea::scaleViewToFitDocumentIfNeeded()
https://bugs.webkit.org/show_bug.cgi?id=193468

Attachment 359284: Patch

https://bugs.webkit.org/attachment.cgi?id=359284&action=review




--- Comment #7 from zalan <zalan at apple.com> ---
Comment on attachment 359284
  --> https://bugs.webkit.org/attachment.cgi?id=359284
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=359284&action=review

> Source/WebKit/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:375
> +    IntSize documentSize = renderView->unscaledDocumentRect().size();

It's probably not the case but this second layoutIfNeeded() could potentially
nuke the frame as well.