[webkit-reviews] review granted: [Bug 193498] clang-tidy: Fix unnecessary copy/ref churn of for loop variables in libwebrtc : [Attachment 359283] Patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 16 11:24:41 PST 2019


youenn fablet <youennf at gmail.com> has granted David Kilzer (:ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 193498: clang-tidy: Fix unnecessary copy/ref churn of for loop variables in
libwebrtc
https://bugs.webkit.org/show_bug.cgi?id=193498

Attachment 359283: Patch v1

https://bugs.webkit.org/attachment.cgi?id=359283&action=review




--- Comment #2 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 359283
  --> https://bugs.webkit.org/attachment.cgi?id=359283
Patch v1

Can we try upstreaming these changes?

View in context: https://bugs.webkit.org/attachment.cgi?id=359283&action=review

>
Source/ThirdParty/libwebrtc/Source/webrtc/modules/rtp_rtcp/source/rtcp_receiver
.cc:440
> +  for (const rtcp::ReportBlock& report_block :
sender_report.report_blocks())

Could use auto here.


More information about the webkit-reviews mailing list