[webkit-reviews] review granted: [Bug 193496] bmalloc should use JSC VM tag for gigacage : [Attachment 359273] Patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Keith Miller
<keith_miller at apple.com>'s request for review:
Bug 193496: bmalloc should use JSC VM tag for gigacage
https://bugs.webkit.org/show_bug.cgi?id=193496

Attachment 359273: Patch

https://bugs.webkit.org/attachment.cgi?id=359273&action=review




--- Comment #3 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 359273
  --> https://bugs.webkit.org/attachment.cgi?id=359273
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=359273&action=review

r=me with fixes and if EWS bots are happy.

> Source/bmalloc/ChangeLog:9
> +	   tag gigacage memory with the unused JSC memory tag. The JSC memory

I think that you should clarify that by "unused", you mean JSGigacagePages i.e.
VM_TAG_FOR_GIGACAGE_MEMORY, instead of UnknownUsage.

> Source/bmalloc/bmalloc.xcodeproj/project.pbxproj:746
> +			   developmentRegion = en;

Fix indentation.