[webkit-reviews] review granted: [Bug 193436] [WHLSL] Implement the recursion checker : [Attachment 359225] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 16 08:40:49 PST 2019


Saam Barati <sbarati at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 193436: [WHLSL] Implement the recursion checker
https://bugs.webkit.org/show_bug.cgi?id=193436

Attachment 359225: Patch

https://bugs.webkit.org/attachment.cgi?id=359225&action=review




--- Comment #7 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 359225
  --> https://bugs.webkit.org/attachment.cgi?id=359225
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=359225&action=review

> Source/WebCore/Modules/webgpu/WHLSL/WHLSLRecursionChecker.cpp:53
> +	   auto success = m_visitingSet.remove(&functionDefinition);

Each AST node representing a call to a function “foo” points to the same memory
location?


More information about the webkit-reviews mailing list