[webkit-reviews] review granted: [Bug 193484] Remove more NetworkProcess::singleton use : [Attachment 359251] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 193484: Remove more NetworkProcess::singleton use
https://bugs.webkit.org/show_bug.cgi?id=193484

Attachment 359251: Patch

https://bugs.webkit.org/attachment.cgi?id=359251&action=review




--- Comment #2 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 359251
  --> https://bugs.webkit.org/attachment.cgi?id=359251
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=359251&action=review

r=me

>
Source/WebKit/NetworkProcess/CustomProtocols/Cocoa/LegacyCustomProtocolManagerC
ocoa.mm:51
> +void LegacyCustomProtocolManager::networkProcessCreated(NetworkProcess&
networkProcess)
> +{
> +    newestNetworkProcess() = &networkProcess;
> +}

I think we expect clients that use LegacyCustomProtocolManager never to make
more than one NetworkProcess, and we expect clients that make more than one
NetworkProcess never to use LegacyCustomProtocolManager. Is that right?

If so, I think it would be clearer to remember the *first* NetworkProcess
created, and ASSERT that, if another one is created,
LegacyCustomProtocolManager has no registered protocols.