[webkit-reviews] review granted: [Bug 193475] VisualViewport API should be updated upon opening of keyboard : [Attachment 359234] Fixes the bug

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Ryosuke Niwa
<rniwa at webkit.org>'s request for review:
Bug 193475: VisualViewport API should be updated upon opening of keyboard
https://bugs.webkit.org/show_bug.cgi?id=193475

Attachment 359234: Fixes the bug

https://bugs.webkit.org/attachment.cgi?id=359234&action=review




--- Comment #2 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 359234
  --> https://bugs.webkit.org/attachment.cgi?id=359234
Fixes the bug

View in context: https://bugs.webkit.org/attachment.cgi?id=359234&action=review

> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:3044
> +	       frameView.didUpdateViewportOverrideRects();

Do we know that the visual viewport actually changed? Perhaps
setVisualViewportOverrideRect() should return a bool and we only call this when
it changes.