[webkit-reviews] review requested: [Bug 193438] [JSC] Use KnownStringUse for GetByVal(Array::String) since AI would offer wider type information and offer non-string type after removing Check(String) : [Attachment 359227] Patch

[bugzilla-daemon at webkit.org]

Keith Miller <keith_miller at apple.com> has asked  for review:
Bug 193438: [JSC] Use KnownStringUse for GetByVal(Array::String) since AI would
offer wider type information and offer non-string type after removing
Check(String)
https://bugs.webkit.org/show_bug.cgi?id=193438

Attachment 359227: Patch

https://bugs.webkit.org/attachment.cgi?id=359227&action=review




--- Comment #12 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 359227
  --> https://bugs.webkit.org/attachment.cgi?id=359227
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=359227&action=review

> Source/JavaScriptCore/ChangeLog:10
> +	   After the first run removes Check(String), it would happen that AI
starts saying the tyep of 1st child is not String.

typo: tyep => type.

> Source/JavaScriptCore/dfg/DFGSSALoweringPhase.cpp:128
> +	       // When we need supporting this, it requires an additional code
since base's useKind is KnownStringUse.

Nit: This should probably be: "When we need to support this, it will require
additional code since base's useKind is KnownStringUse."