[webkit-reviews] review granted: [Bug 193438] [JSC] Use KnownStringUse for GetByVal(Array::String) since AI would offer wider type information and offer non-string type after removing Check(String) : [Attachment 359227] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Yusuke Suzuki
<yusukesuzuki at slowstart.org>'s request for review:
Bug 193438: [JSC] Use KnownStringUse for GetByVal(Array::String) since AI would
offer wider type information and offer non-string type after removing
Check(String)
https://bugs.webkit.org/show_bug.cgi?id=193438

Attachment 359227: Patch

https://bugs.webkit.org/attachment.cgi?id=359227&action=review




--- Comment #11 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 359227
  --> https://bugs.webkit.org/attachment.cgi?id=359227
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=359227&action=review

> Source/JavaScriptCore/dfg/DFGSSALoweringPhase.cpp:129
> +	       RELEASE_ASSERT_NOT_REACHED();

DFG_ASSERT please.