[webkit-reviews] review canceled: [Bug 193438] [JSC] CSE breaks the previous proven AI's AbstractValue : [Attachment 359220] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 15 16:31:42 PST 2019


Yusuke Suzuki <yusukesuzuki at slowstart.org> has canceled Yusuke Suzuki
<yusukesuzuki at slowstart.org>'s request for review:
Bug 193438: [JSC] CSE breaks the previous proven AI's AbstractValue
https://bugs.webkit.org/show_bug.cgi?id=193438

Attachment 359220: Patch

https://bugs.webkit.org/attachment.cgi?id=359220&action=review




--- Comment #6 from Yusuke Suzuki <yusukesuzuki at slowstart.org> ---
Comment on attachment 359220
  --> https://bugs.webkit.org/attachment.cgi?id=359220
Patch

GetArrayLength is expecting KnownCellUse. And it is OK. But in FTL, we emit
GetArrayLength from GetByVal to lower CheckInBounds. At that time, it becomes
GetArrayLength(KnownStringUse). We should support
GetArrayLength(KnownStringUse) too.


More information about the webkit-reviews mailing list