[webkit-reviews] review granted: [Bug 193469] [WHLSL] Delete the 'restricted' keyword : [Attachment 359215] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jan 15 16:00:07 PST 2019
Robin Morisset <rmorisset at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 193469: [WHLSL] Delete the 'restricted' keyword
https://bugs.webkit.org/show_bug.cgi?id=193469
Attachment 359215: Patch
https://bugs.webkit.org/attachment.cgi?id=359215&action=review
--- Comment #2 from Robin Morisset <rmorisset at apple.com> ---
Comment on attachment 359215
--> https://bugs.webkit.org/attachment.cgi?id=359215
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=359215&action=review
LGTM
> Source/WebCore/Modules/webgpu/WHLSL/WHLSLResolveOverloadImpl.cpp:74
> + if (minimumCostCandidates.size() == 1)
Maybe rename minimumCostCandidates, since I don't think there is a notion of
cost anymore.
More information about the webkit-reviews
mailing list