[webkit-reviews] review granted: [Bug 193466] Fix incorrect ASSERT added in r239840 : [Attachment 359209] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jan 15 15:15:43 PST 2019
youenn fablet <youennf at gmail.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 193466: Fix incorrect ASSERT added in r239840
https://bugs.webkit.org/show_bug.cgi?id=193466
Attachment 359209: Patch
https://bugs.webkit.org/attachment.cgi?id=359209&action=review
--- Comment #3 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 359209
--> https://bugs.webkit.org/attachment.cgi?id=359209
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=359209&action=review
> Source/WebKit/WebProcess/cocoa/UserMediaCaptureManager.cpp:65
> + ASSERT(deviceType == CaptureDevice::DeviceType::Camera || deviceType
== CaptureDevice::DeviceType::Screen || deviceType ==
CaptureDevice::DeviceType::Window || deviceType ==
CaptureDevice::DeviceType::Microphone);
Should it be ASSERT(deviceType != CaptureDevice::DeviceType::Unknown)?
More information about the webkit-reviews
mailing list