[webkit-reviews] review granted: [Bug 185545] Add release logging for incoming and outgoing webrtc audio tracks : [Attachment 340186] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 185545: Add release logging for incoming and outgoing webrtc audio tracks
https://bugs.webkit.org/show_bug.cgi?id=185545

Attachment 340186: Patch

https://bugs.webkit.org/attachment.cgi?id=340186&action=review




--- Comment #7 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 340186
  --> https://bugs.webkit.org/attachment.cgi?id=340186
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=340186&action=review

>
Source/WebCore/platform/mediastream/mac/RealtimeIncomingAudioSourceCocoa.cpp:78
> +    if (!(++m_chunksReceived % 100))

Nit: it would be useful to log a unique identifier to help debug cases with
more than one track.

>
Source/WebCore/platform/mediastream/mac/RealtimeOutgoingAudioSourceCocoa.cpp:16
1
> +	       RELEASE_LOG(MediaStream,
"RealtimeOutgoingAudioSourceCocoa::pullAudioData %zu chunk", m_chunksSent);

Ditto

> Source/WebKit/WebProcess/cocoa/UserMediaCaptureManager.cpp:237
> +	   RELEASE_LOG(MediaStream,
"UserMediaCaptureManager::audioSamplesAvailable %zu chunk for %llu",
m_receivedSamples, id);

Ditto