[webkit-reviews] review granted: [Bug 193423] JSFunction::canUseAllocationProfile() should account for builtin functions with no own prototypes. : [Attachment 359137] proposed patch.

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 193423: JSFunction::canUseAllocationProfile() should account for builtin
functions with no own prototypes.
https://bugs.webkit.org/show_bug.cgi?id=193423

Attachment 359137: proposed patch.

https://bugs.webkit.org/attachment.cgi?id=359137&action=review




--- Comment #4 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 359137
  --> https://bugs.webkit.org/attachment.cgi?id=359137
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=359137&action=review

r=me

> Source/JavaScriptCore/ChangeLog:10
> +	   because the majority of them has no prototype property.  The only
exception to

s/has/have

> Source/JavaScriptCore/runtime/JSFunctionInlines.h:120
> +	   if (!prototype || (attributes &
PropertyAttribute::AccessorOrCustomAccessorOrValue))

Can we add a test case for this? Like define a getter as the prototype of a
random builtin function.