[webkit-reviews] review granted: [Bug 193361] Regression(PSON) View becomes blank after click a cross-site download link : [Attachment 359169] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 193361: Regression(PSON) View becomes blank after click a cross-site
download link
https://bugs.webkit.org/show_bug.cgi?id=193361

Attachment 359169: Patch

https://bugs.webkit.org/attachment.cgi?id=359169&action=review




--- Comment #36 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 359169
  --> https://bugs.webkit.org/attachment.cgi?id=359169
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=359169&action=review

r=me

Nice and risky, just like a good old JSC patch!

> Source/WebKit/UIProcess/WebPageProxy.cpp:554
> +DrawingAreaProxy* WebPageProxy::drawingArea() const
> +{
> +    if (m_provisionalPage && m_process.ptr() ==
&m_provisionalPage->process() && m_provisionalPage->drawingArea())
> +	   return m_provisionalPage->drawingArea();
> +    return m_drawingArea.get();
> +}

Why do we want to return the drawing area of the provisional page? My
understanding is that we prefer to "lock the layer tree" and avoid drawing a
page until it becomes committed.

> Source/WebKit/UIProcess/WebPageProxy.cpp:3886
> +	   // The load did not fail, it merely happening in a new provisional
process.

it is merely happening