[webkit-reviews] review granted: [Bug 193429] Split headerValueForVary into specialized functions for NetworkProcess and WebProcess/WebKitLegacy : [Attachment 359127] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 193429: Split headerValueForVary into specialized functions for
NetworkProcess and WebProcess/WebKitLegacy
https://bugs.webkit.org/show_bug.cgi?id=193429

Attachment 359127: Patch

https://bugs.webkit.org/attachment.cgi?id=359127&action=review




--- Comment #2 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 359127
  --> https://bugs.webkit.org/attachment.cgi?id=359127
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=359127&action=review

r=me

> Source/WebCore/platform/network/CacheValidation.cpp:346
> +	   return cookieRequestHeaderFieldValue();

I was confused for a while that this was the parameter name and not one of the
static functions. Might be nice to give this a different name that doesn't
clash, or maybe that was your intention.

> Source/WebCore/platform/network/CacheValidation.cpp:407
> +    return verifyVaryingRequestHeaders(varyingRequestHeaders, [&] (const
String& headerName) {

Do we want to maintain the assert, and potentially change it later?

    ASSERT(sessionID == PAL::SessionID::defaultSessionID());