[webkit-reviews] review granted: [Bug 193149] Web Inspector: Audit: create new IDL type for exposing special functionality in test context : [Attachment 359118] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 193149: Web Inspector: Audit: create new IDL type for exposing special
functionality in test context
https://bugs.webkit.org/show_bug.cgi?id=193149

Attachment 359118: Patch

https://bugs.webkit.org/attachment.cgi?id=359118&action=review




--- Comment #32 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 359118
  --> https://bugs.webkit.org/attachment.cgi?id=359118
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=359118&action=review

r=me! Very nice

> Source/JavaScriptCore/inspector/agents/InspectorAuditAgent.cpp:102
> +    options.includeCommandLineAPI = true;

Should we be including the command line API?! That means they would have
`getEventListeners` and we wouldn't need our (future) DOM additions. I feel
like we shouldn't include the command line API.