[webkit-reviews] review denied: [Bug 193423] JSFunction::canUseAllocationProfile() should account for builtin functions with no own prototypes. : [Attachment 359116] proposed patch.

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has denied Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 193423: JSFunction::canUseAllocationProfile() should account for builtin
functions with no own prototypes.
https://bugs.webkit.org/show_bug.cgi?id=193423

Attachment 359116: proposed patch.

https://bugs.webkit.org/attachment.cgi?id=359116&action=review




--- Comment #2 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 359116
  --> https://bugs.webkit.org/attachment.cgi?id=359116
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=359116&action=review

> Source/JavaScriptCore/runtime/JSFunctionInlines.h:125
> +	   if (prototype.isCell()) {
> +	       JSCell* cell = prototype.asCell();
> +	       if (cell->isGetterSetter() || cell->isCustomGetterSetter() ||
cell->isProxy())
> +		   return false;
> +	   }

Not a fan of this. Can you do the structure lookup along w/ and inspect the
bits that say if this is a getter/setter?