[webkit-reviews] review granted: [Bug 193411] Bulgarian TLD should not punycode-encode URLs with Bulgarian Cyrillic characters : [Attachment 359083] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 14 16:50:43 PST 2019


Alexey Proskuryakov <ap at webkit.org> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 193411: Bulgarian TLD should not punycode-encode URLs with Bulgarian
Cyrillic characters
https://bugs.webkit.org/show_bug.cgi?id=193411

Attachment 359083: Patch

https://bugs.webkit.org/attachment.cgi?id=359083&action=review




--- Comment #2 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 359083
  --> https://bugs.webkit.org/attachment.cgi?id=359083
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=359083&action=review

> Source/WTF/wtf/cocoa/NSURLExtras.mm:550
> +	   return (ch >= 0x0430 && ch <= 0x044A) || ch == 0x044C || (ch >=
0x044E && ch <= 0x0450) || ch == 0x045D || isASCIIDigit(ch) || ch == '-';

Surprised by U+0450 and 0x045D, but if ICANN says so...


More information about the webkit-reviews mailing list