[webkit-reviews] review granted: [Bug 192966] DFGByteCodeParser rules for bitwise operations should consider type of their operands : [Attachment 358784] Patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <yusukesuzuki at slowstart.org> has granted Caio Lima
<ticaiolima at gmail.com>'s request for review:
Bug 192966: DFGByteCodeParser rules for bitwise operations should consider type
of their operands
https://bugs.webkit.org/show_bug.cgi?id=192966

Attachment 358784: Patch

https://bugs.webkit.org/attachment.cgi?id=358784&action=review




--- Comment #11 from Yusuke Suzuki <yusukesuzuki at slowstart.org> ---
Comment on attachment 358784
  --> https://bugs.webkit.org/attachment.cgi?id=358784
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=358784&action=review

r=me

> Source/JavaScriptCore/ChangeLog:11
> +	   for ValueBitOp to use `getHeapPrediction()`. 

Can we have a test to ensure that JSC does not perform compile-fail loops?
Like the following code would pose the issue if something is wrong.

var object = { valueOf() { return integer; } };
// object with bit operation, which will produce Int32, but the operands of bit
operation includes object.