[webkit-reviews] review granted: [Bug 193249] Web Inspector: Event breakpoints: text field and completion popover fonts should match : [Attachment 358628] Patch

[bugzilla-daemon at webkit.org]

Matt Baker <mattbaker at apple.com> has granted Devin Rousso <drousso at apple.com>'s
request for review:
Bug 193249: Web Inspector: Event breakpoints: text field and completion popover
fonts should match
https://bugs.webkit.org/show_bug.cgi?id=193249

Attachment 358628: Patch

https://bugs.webkit.org/attachment.cgi?id=358628&action=review




--- Comment #3 from Matt Baker <mattbaker at apple.com> ---
Comment on attachment 358628
  --> https://bugs.webkit.org/attachment.cgi?id=358628
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=358628&action=review

r=me

>> Source/WebInspectorUI/UserInterface/Views/EventBreakpointPopover.js:199
>> +	    rect.size.width -= padding +
parseInt(computedStyle.borderRightWidth) +
parseInt(computedStyle.paddingRight);
> 
> `rect.size.width` doesn't seem to be used by this._suggestionsView.show.

This is an implementation detail; we could change the signature if we really
wanted:

show(anchorOrigin, anchorHeight) or just show(origin, anchorHeight)