[webkit-reviews] review granted: [Bug 193372] [JSC] Do not use asArrayModes() with Structures because it discards TypedArray information : [Attachment 359004] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Yusuke Suzuki
<yusukesuzuki at slowstart.org>'s request for review:
Bug 193372: [JSC] Do not use asArrayModes() with Structures because it discards
TypedArray information
https://bugs.webkit.org/show_bug.cgi?id=193372

Attachment 359004: Patch

https://bugs.webkit.org/attachment.cgi?id=359004&action=review




--- Comment #18 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 359004
  --> https://bugs.webkit.org/attachment.cgi?id=359004
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=359004&action=review

r=me

> Source/JavaScriptCore/bytecode/ArrayProfile.cpp:41
> +const ArrayModes TypedArrayModes[NumberOfTypedArrayTypesExcludingDataView] =
{

Should "TypedArrayModes" should be capitalized according to our style
guidelines?