[webkit-reviews] review granted: [Bug 193402] Fix all CLoop JSC test failures (including some LLInt bugs due to recent bytecode format change). : [Attachment 359057] proposed patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 14 12:42:41 PST 2019


Keith Miller <keith_miller at apple.com> has granted Mark Lam
<mark.lam at apple.com>'s request for review:
Bug 193402: Fix all CLoop JSC test failures (including some LLInt bugs due to
recent bytecode format change).
https://bugs.webkit.org/show_bug.cgi?id=193402

Attachment 359057: proposed patch.

https://bugs.webkit.org/attachment.cgi?id=359057&action=review




--- Comment #2 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 359057
  --> https://bugs.webkit.org/attachment.cgi?id=359057
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=359057&action=review

r=me.

> Source/JavaScriptCore/ChangeLog:108
> +	   64bit ASM LLLint (without JIT), 64bit and 32bit X86 CLoop, and ARMv7
Cloop.

Nit: note this only on x86.


More information about the webkit-reviews mailing list