[webkit-reviews] review granted: [Bug 193098] Web Inspector: Styles: pressing Down key on empty value field shouldn't discard completion popover : [Attachment 358986] Patch

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Nikita Vasilyev
<nvasilyev at apple.com>'s request for review:
Bug 193098: Web Inspector: Styles: pressing Down key on empty value field
shouldn't discard completion popover
https://bugs.webkit.org/show_bug.cgi?id=193098

Attachment 358986: Patch

https://bugs.webkit.org/attachment.cgi?id=358986&action=review




--- Comment #14 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 358986
  --> https://bugs.webkit.org/attachment.cgi?id=358986
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=358986&action=review

r=me, I'm still not a fan of keeping `setInterval` and `getBoundingClientRect`,
but in the interest of time, as well as the fact that this shouldn't be any
worse than what we had before, I'll say fine.  Please open a followup to see if
we can address these issues (e.g. "Web Inspector: WI.CompletionSuggestionsView
shouldn't use setInterval/getBoundingClientRect to determine if the target
element has moved").

> Source/WebInspectorUI/UserInterface/Views/CompletionSuggestionsView.js:36
> +	   this._moveIntervalIdentifier = 0;

NIT: we normally set identifiers to `undefined` (or `null`).

> Source/WebInspectorUI/UserInterface/Views/CompletionSuggestionsView.js:260
> +	   this._moveIntervalIdentifier = 0;

Ditto (>36).

> Source/WebInspectorUI/UserInterface/Views/SpreadsheetTextField.js:308
> +		   this._suggestionsView.scrollTop = scrollTop;

Can this be moved inside `WI.CompletionSuggestionView.prototype.show`?	It
seems odd to require the caller to re-scroll the element when the element is
added within `WI.CompletionSuggestionView`.