[webkit-reviews] review granted: [Bug 191121] JSC should have a module loader API : [Attachment 359054] Patch

[bugzilla-daemon at webkit.org]

Michael Saboff <msaboff at apple.com> has granted Keith Miller
<keith_miller at apple.com>'s request for review:
Bug 191121: JSC should have a module loader API
https://bugs.webkit.org/show_bug.cgi?id=191121

Attachment 359054: Patch

https://bugs.webkit.org/attachment.cgi?id=359054&action=review




--- Comment #20 from Michael Saboff <msaboff at apple.com> ---
Comment on attachment 359054
  --> https://bugs.webkit.org/attachment.cgi?id=359054
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=359054&action=review

r=me after EWS is green.

> Source/JavaScriptCore/API/JSContextPrivate.h:37
> +/*! @abstract Provides source code for any JS module that is actively
imported.

Shouldn't there be an @method and @abstract on its own line.

> Source/JavaScriptCore/API/JSContextPrivate.h:74
> +/*! @abstract The delegate the context will use when trying to load a
module. Note, this delegate will be ignored for contexts returned by UIWebView.
*/

Shouldn't @property be above @abstract and both on their own lines.