[webkit-reviews] review granted: [Bug 193080] [WHLSL] Implement the Type Checker : [Attachment 359019] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 14 10:35:09 PST 2019


Dean Jackson <dino at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 193080: [WHLSL] Implement the Type Checker
https://bugs.webkit.org/show_bug.cgi?id=193080

Attachment 359019: Patch

https://bugs.webkit.org/attachment.cgi?id=359019&action=review




--- Comment #19 from Dean Jackson <dino at apple.com> ---
Comment on attachment 359019
  --> https://bugs.webkit.org/attachment.cgi?id=359019
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=359019&action=review

rs=me

> Source/WebCore/Modules/webgpu/WHLSL/WHLSLChecker.cpp:166
> +    if (callExpression.name() == "operator&[]" && types.size() == 2) {

Ditto a previous comment about using raw strings.


More information about the webkit-reviews mailing list