[webkit-reviews] review requested: [Bug 193260] Web Inspector: Event breakpoints: up/down keys don't always work : [Attachment 358657] Patch

[bugzilla-daemon at webkit.org]

Nikita Vasilyev <nvasilyev at apple.com> has asked  for review:
Bug 193260: Web Inspector: Event breakpoints: up/down keys don't always work
https://bugs.webkit.org/show_bug.cgi?id=193260

Attachment 358657: Patch

https://bugs.webkit.org/attachment.cgi?id=358657&action=review




--- Comment #5 from Nikita Vasilyev <nvasilyev at apple.com> ---
Comment on attachment 358657
  --> https://bugs.webkit.org/attachment.cgi?id=358657
Patch

Reseting back to "r?".

(In reply to Devin Rousso from comment #4)
> This code is trying to find the closest item to the selected item that
> existed in the previous list _and_ exists in the new list.
>  1. create an event breakpoint
>  2. type "c" to filter by event names starting with "c"
>  3. arrow down to "change"
>  4. type "l" to filter by event names starting with "cl"

Only two events start with "cl":
- click
- close

I agree that we should select "click". However, I think we should just select
the 1st item on the list.

If you replace the 3rd step with "arrow down to 'cut', which is the last item
on the list",
do you think we it's beneficial to select "close" instead of "click"?