[webkit-reviews] review requested: [Bug 193262] Web Inspector: expose Audit and Recording versions to the frontend : [Attachment 359000] Patch

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has asked  for review:
Bug 193262: Web Inspector: expose Audit and Recording versions to the frontend
https://bugs.webkit.org/show_bug.cgi?id=193262

Attachment 359000: Patch

https://bugs.webkit.org/attachment.cgi?id=359000&action=review




--- Comment #4 from Devin Rousso <drousso at apple.com> ---
Created attachment 359000

  --> https://bugs.webkit.org/attachment.cgi?id=359000&action=review

Patch

Removed the UI parts of this patch to focus more on the functionality.
Added a requirement that the system version be kept in sync with the frontend
version (enforced by a test) so that when doing a "compatibility" check we only
need to do compare the listed version against the minimum of the system and
frontend versions:
 - if system < version < frontend (newer frontend connected to older backend),
then we lack required functionality
 - if frontend < version < system (older frontend connected to newer backend),
then we are able to run the audit, but may be unable to display certain result
values
 - if version < system <=> frontend, the test is fully supported
 - if system <=> frontend < version, the test is not supported