[webkit-reviews] review granted: [Bug 193383] [LFC] Block/InlinFormattingContext should take Block/InlineFormattingState : [Attachment 358995] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted zalan <zalan at apple.com>'s request
for review:
Bug 193383: [LFC] Block/InlinFormattingContext should take
Block/InlineFormattingState
https://bugs.webkit.org/show_bug.cgi?id=193383

Attachment 358995: Patch

https://bugs.webkit.org/attachment.cgi?id=358995&action=review




--- Comment #2 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 358995
  --> https://bugs.webkit.org/attachment.cgi?id=358995
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=358995&action=review

> Source/WebCore/layout/FormattingContext.h:-68
> -    FormattingState& formattingState() const;

I think you could also keep this as-is (and keep m_formattingState private).
You can override a function with a more specific return type in the subclass:

BlockFormattingState& formattingState() const { return
downcast<BlockFormattingState>(FormattingContext::formattingState()); }