[webkit-reviews] review granted: [Bug 191655] Have prefers-color-scheme: light always match on macOS versions before Mojave : [Attachment 358967] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jan 11 17:40:18 PST 2019
Megan Gardner <megan_gardner at apple.com> has granted Timothy Hatcher
<timothy at apple.com>'s request for review:
Bug 191655: Have prefers-color-scheme: light always match on macOS versions
before Mojave
https://bugs.webkit.org/show_bug.cgi?id=191655
Attachment 358967: Patch
https://bugs.webkit.org/attachment.cgi?id=358967&action=review
--- Comment #4 from Megan Gardner <megan_gardner at apple.com> ---
Comment on attachment 358967
--> https://bugs.webkit.org/attachment.cgi?id=358967
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=358967&action=review
> Source/WebCore/page/Page.cpp:2679
> }
Does 'value' not need to be marked as UNUSED?
> Source/WebCore/page/Page.cpp:2704
> +#endif
Does 'valueOverride' not need to be marked as UNUSED?
More information about the webkit-reviews
mailing list