[webkit-reviews] review granted: [Bug 193332] [WPE] Workaround for incorrect template specialization being selected when UChar=char16_t : [Attachment 358821] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has granted Charlie Turner
<cturner at igalia.com>'s request for review:
Bug 193332: [WPE] Workaround for incorrect template specialization being
selected when UChar=char16_t
https://bugs.webkit.org/show_bug.cgi?id=193332

Attachment 358821: Patch

https://bugs.webkit.org/attachment.cgi?id=358821&action=review




--- Comment #2 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 358821
  --> https://bugs.webkit.org/attachment.cgi?id=358821
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=358821&action=review

> Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:88
> -#if PLATFORM(WIN)
> +#if PLATFORM(WIN) || U_ICU_VERSION_MAJOR_NUM >= 59
>      EXPECT_EQ("hello 42 world", makeString("hello ", static_cast<unsigned
short>(42) , " world"));
>  #else
>      EXPECT_EQ("hello * world", makeString("hello ", static_cast<unsigned
short>(42) , " world")); // Treated as a character.

I wonder how many bugs this behavior difference is causing. This is really
unfortunate. :/

I almost gave this r-, but the new version is better and the old approach will
be obsoleted eventually. Can we remove the #if PLATFORM(WIN), though? Surely
that is there because they were using newer ICU?