[webkit-reviews] review granted: [Bug 192210] Web Inspector: Audit: allow audits to be enabled/disabled : [Attachment 358868] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 192210: Web Inspector: Audit: allow audits to be enabled/disabled
https://bugs.webkit.org/show_bug.cgi?id=192210

Attachment 358868: Patch

https://bugs.webkit.org/attachment.cgi?id=358868&action=review




--- Comment #7 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 358868
  --> https://bugs.webkit.org/attachment.cgi?id=358868
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=358868&action=review

> Source/WebInspectorUI/UserInterface/Controllers/AuditManager.js:81
> +	       let saveDisabled = (test) => {

Might be better to have a more searchable name: saveDisabledDefaultTest.

> Source/WebInspectorUI/UserInterface/Controllers/AuditManager.js:303
> +	   let checkDisabled = (test) => {

Might be better to have a more searchable name: checkDisabledDefaultTest.