[webkit-reviews] review granted: [Bug 193064] Test group results page from notification should not failed even for completed build type build requests. : [Attachment 358168] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted dewei_zhu at apple.com's request for
review:
Bug 193064: Test group results page from notification should not failed even
for completed build type build requests.
https://bugs.webkit.org/show_bug.cgi?id=193064

Attachment 358168: Patch

https://bugs.webkit.org/attachment.cgi?id=358168&action=review




--- Comment #2 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 358168
  --> https://bugs.webkit.org/attachment.cgi?id=358168
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=358168&action=review

> Websites/perf.webkit.org/ChangeLog:3
> +	   Test group results page from notification should not failed even for
completed build type build requests.

Should probably revise this to say "Test group results notification should not
say a build request to build had failed even when it had successfully
completed"

> Websites/perf.webkit.org/tools/js/test-group-result-page.js:110
> +		       cellValue = 'failed';

Should be capitalized.