[webkit-reviews] review requested: [Bug 192210] Web Inspector: Audit: allow audits to be enabled/disabled : [Attachment 358868] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 10 20:35:47 PST 2019


Devin Rousso <drousso at apple.com> has asked  for review:
Bug 192210: Web Inspector: Audit: allow audits to be enabled/disabled
https://bugs.webkit.org/show_bug.cgi?id=192210

Attachment 358868: Patch

https://bugs.webkit.org/attachment.cgi?id=358868&action=review




--- Comment #6 from Devin Rousso <drousso at apple.com> ---
Created attachment 358868

  --> https://bugs.webkit.org/attachment.cgi?id=358868&action=review

Patch

Merged <https://webkit.org/b/192211> into this change, as there were issues
with reloading audit test groups from the IndexedDB due to the fact that the
`disabled` value wasn't propagated to the sub-tests, meaning that they would
always appear as not disabled (since the children wouldn't be disabled) even
though the actual model object would be disabled.


More information about the webkit-reviews mailing list