[webkit-reviews] review granted: [Bug 193109] Introduce IDL files for runtime-enabled UndoManager and UndoItem JavaScript API : [Attachment 358847] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 193109: Introduce IDL files for runtime-enabled UndoManager and UndoItem
JavaScript API
https://bugs.webkit.org/show_bug.cgi?id=193109

Attachment 358847: Patch

https://bugs.webkit.org/attachment.cgi?id=358847&action=review




--- Comment #3 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 358847
  --> https://bugs.webkit.org/attachment.cgi?id=358847
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=358847&action=review

> Source/WebCore/page/UndoItem.idl:35
> +    Constructor(DOMString label, UndoItemInit initDict)

We might wanna consider making label simply an attribute of UndoItemInit.

> Source/WebCore/page/UndoManager.h:37
> +class UndoManager : public RefCounted<UndoManager> {
> +public:

Maybe make it fast allocated & iso-heaped?

> Source/WebCore/page/UndoManager.h:43
> +    virtual ~UndoManager() = default;

I don't think we need this.
Just add ImplementationLacksVTable to IDL.

> Source/WebCore/page/UndoManager.idl:27
> +    EnabledAtRuntime=UndoManagerAPI

Add GenerateIsReachable=ImplDocument. Add a test if possible too.

> LayoutTests/ChangeLog:13
> +	   * editing/undo/UndoManager/undo-manager-interfaces-expected.txt:
Added.
> +	   * editing/undo/UndoManager/undo-manager-interfaces.html: Added.

Why don't we just add it to editing/undo-manager/