[webkit-reviews] review granted: [Bug 193314] Support parsing of additional values for the touch-action property : [Attachment 358788] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Antoine Quint <graouts at apple.com>'s
request for review:
Bug 193314: Support parsing of additional values for the touch-action property
https://bugs.webkit.org/show_bug.cgi?id=193314

Attachment 358788: Patch

https://bugs.webkit.org/attachment.cgi?id=358788&action=review




--- Comment #5 from Dean Jackson <dino at apple.com> ---
Comment on attachment 358788
  --> https://bugs.webkit.org/attachment.cgi?id=358788
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=358788&action=review

> Source/WebCore/css/StyleBuilderConverter.h:1359
> +	       auto& primitiveValue =
downcast<CSSPrimitiveValue>(currentValue.get());

Is this always safe?

> Source/WebCore/css/StyleBuilderConverter.h:1361
> +	       if (primitiveValueID != CSSValuePanX && primitiveValueID !=
CSSValuePanY && primitiveValueID != CSSValuePinchZoom)

So "none pan-x" evaluates to be "none" (initial)?

> Source/WebCore/css/parser/CSSPropertyParser.cpp:1349
> +    RefPtr<CSSValueList> list = CSSValueList::createSpaceSeparated();

auto?

> Source/WebCore/css/parser/CSSPropertyParser.cpp:1351
> +	   RefPtr<CSSPrimitiveValue> ident = consumeIdent<CSSValuePanX,
CSSValuePanY, CSSValuePinchZoom>(range);

auto?

> Source/WebCore/dom/Element.cpp:106
> +#include "TouchAction.h"

Is it used in this file?

> Source/WebCore/platform/TouchAction.h:2
> + * Copyright (C) 2018 Apple Inc. All rights reserved.

2019.

> Source/WebCore/platform/TouchAction.h:17
> + * This library is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU Library General Public
> + * License as published by the Free Software Foundation; either
> + * version 2 of the License, or (at your option) any later version.
> + *
> + * This library is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> + * Library General Public License for more details.
> + *
> + * You should have received a copy of the GNU Library General Public License
> + * along with this library; see the file COPYING.LIB.  If not, write to
> + * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
> + * Boston, MA 02110-1301, USA.

Why are you using the GPL? Use the normal license.

> Source/WebCore/rendering/style/RenderStyle.h:1227
> +    void setTouchAction(OptionSet<TouchAction> ta) {
SET_VAR(m_rareNonInheritedData, touchAction, ta.toRaw()); }

ugh. why not use "touchAction" rather than "ta"?

(or "touchActions")