[webkit-reviews] review denied: [Bug 193167] IndexedDB: leak IDBTransaction, TransactionOperation and IDBRequest in layout tests : [Attachment 358803] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has denied  review:
Bug 193167: IndexedDB: leak IDBTransaction, TransactionOperation and IDBRequest
in layout tests
https://bugs.webkit.org/show_bug.cgi?id=193167

Attachment 358803: Patch

https://bugs.webkit.org/attachment.cgi?id=358803&action=review




--- Comment #7 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 358803
  --> https://bugs.webkit.org/attachment.cgi?id=358803
Patch

Seems like these test failures are related:

  crypto/subtle/rsa-indexeddb-private.html [ Crash ]
  crypto/subtle/rsa-indexeddb.html [ Crash ]
  fast/history/page-cache-indexed-opened-db.html [ Crash ]
  http/tests/IndexedDB/collect-IDB-objects.https.html [ Crash ]
  http/tests/security/cross-origin-worker-indexeddb.html [ Crash ]
  imported/blink/storage/indexeddb/blob-basics-metadata.html [ Crash ]
  imported/blink/storage/indexeddb/blob-valid-before-commit.html [ Crash ]
  imported/blink/storage/indexeddb/empty-blob-file.html [ Crash ]
  imported/w3c/IndexedDB-private-browsing/abort-in-initial-upgradeneeded.html [
Crash ]
  imported/w3c/IndexedDB-private-browsing/close-in-upgradeneeded.html [ Crash ]
  imported/w3c/IndexedDB-private-browsing/cursor-overloads.html [ Crash ]
  imported/w3c/IndexedDB-private-browsing/idbcursor-advance-continue-async.html
[ Crash ]
  imported/w3c/IndexedDB-private-browsing/idbcursor-advance-invalid.html [
Crash ]
  imported/w3c/IndexedDB-private-browsing/idbcursor-advance.html [ Crash ]
  imported/w3c/IndexedDB-private-browsing/idbcursor-continue.html [ Crash ]
  imported/w3c/web-platform-tests/IndexedDB/close-in-upgradeneeded.html [ Crash
]
  imported/w3c/web-platform-tests/IndexedDB/cursor-overloads.htm [ Crash ]
  imported/w3c/web-platform-tests/IndexedDB/delete-request-queue.html [ Crash ]
  imported/w3c/web-platform-tests/IndexedDB/error-attributes.html [ Crash ]
  imported/w3c/web-platform-tests/IndexedDB/event-dispatch-active-flag.html [
Crash ]
  imported/w3c/web-platform-tests/IndexedDB/fire-error-event-exception.html [
Crash ]
  imported/w3c/web-platform-tests/IndexedDB/fire-success-event-exception.html [
Crash ]
  inspector/indexeddb/requestData.html [ Crash ]
  inspector/indexeddb/requestDatabase.html [ Crash ]
  inspector/indexeddb/requestDatabaseNames.html [ Crash ]
  inspector/unit-tests/objectStore/add.html [ Crash ]
  inspector/unit-tests/objectStore/addObject.html [ Crash ]
  inspector/unit-tests/objectStore/basic.html [ Crash ]