[webkit-reviews] review denied: [Bug 193324] [macOS] Change name of IORegistry key in sandbox. : [Attachment 358801] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has denied Per Arne Vollan
<pvollan at apple.com>'s request for review:
Bug 193324: [macOS] Change name of IORegistry key in sandbox.
https://bugs.webkit.org/show_bug.cgi?id=193324

Attachment 358801: Patch

https://bugs.webkit.org/attachment.cgi?id=358801&action=review




--- Comment #3 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 358801
  --> https://bugs.webkit.org/attachment.cgi?id=358801
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=358801&action=review

I don't think this is right.

> Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:251
> +    (iokit-property-regex
#"^IOGVA(BGRAEnc|Codec|EncoderRestricted|Scaler|HEVCDecodeCapabilities)")

This will cause this to break if someone runs STP on an older OS..

I think this should be:

(iokit-property-regex
#"^IOGVA(BGRAEnc|Codec|EncoderRestricted|Scaler|VTCapabilities|HEVCDecodeCapabi
lities)")