[webkit-reviews] review granted: [Bug 193309] Safari Crashing in Version 12.0.1 (14606.2.104.1.1) WebCore::GraphicsLayerCA::updateBackdropFilters : [Attachment 358765] Patch

[bugzilla-daemon at webkit.org]

Antoine Quint <graouts at apple.com> has granted Dean Jackson <dino at apple.com>'s
request for review:
Bug 193309: Safari Crashing in Version 12.0.1 (14606.2.104.1.1)
WebCore::GraphicsLayerCA::updateBackdropFilters
https://bugs.webkit.org/show_bug.cgi?id=193309

Attachment 358765: Patch

https://bugs.webkit.org/attachment.cgi?id=358765&action=review




--- Comment #3 from Antoine Quint <graouts at apple.com> ---
Comment on attachment 358765
  --> https://bugs.webkit.org/attachment.cgi?id=358765
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=358765&action=review

> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2157
> +	   if (backdropFilterRect.width() > 0 && backdropFilterRect.height() >
0) {

Should `canHaveBackdropFilters` be set to true in case either the width or
height is 0? Also, do we need the `> 0` check? I assume these values can't be
negative.