[webkit-reviews] review granted: [Bug 193266] Replace SessionTracker with HashMap member of NetworkProcess : [Attachment 358720] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 9 19:04:14 PST 2019


Joseph Pecoraro <joepeck at webkit.org> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 193266: Replace SessionTracker with HashMap member of NetworkProcess
https://bugs.webkit.org/show_bug.cgi?id=193266

Attachment 358720: Patch

https://bugs.webkit.org/attachment.cgi?id=358720&action=review




--- Comment #9 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 358720
  --> https://bugs.webkit.org/attachment.cgi?id=358720
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=358720&action=review

r=me

> Source/WebKit/NetworkProcess/Downloads/DownloadManager.h:75
> +	   virtual NetworkSession* networkSession(const PAL::SessionID&) = 0;

This looks like a getter, could be made const, but not really important.


More information about the webkit-reviews mailing list