[webkit-reviews] review granted: [Bug 193298] [WebGPU] Add BindGroupBinding, BindGroupDescriptor, and BufferBinding dictionaries from API : [Attachment 358745] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Justin Fan <justin_fan at apple.com>'s
request for review:
Bug 193298: [WebGPU] Add BindGroupBinding, BindGroupDescriptor, and
BufferBinding dictionaries from API
https://bugs.webkit.org/show_bug.cgi?id=193298

Attachment 358745: Patch

https://bugs.webkit.org/attachment.cgi?id=358745&action=review




--- Comment #4 from Dean Jackson <dino at apple.com> ---
Comment on attachment 358745
  --> https://bugs.webkit.org/attachment.cgi?id=358745
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=358745&action=review

> Source/WebCore/Modules/webgpu/WebGPUBindGroupBinding.h:32
> +#include "WebGPUTextureView.h"
> +

No need for this blank line.

> Source/WebCore/Modules/webgpu/WebGPUBindGroupDescriptor.h:33
> +#include "WebGPUBindGroupLayout.h"
> +
> +#include <wtf/Vector.h>

No need for this blank line.

> Source/WebCore/Modules/webgpu/WebGPUBufferBinding.h:30
> +#include "WebGPUBuffer.h"

I think this file should #include RefPtr.h too.

> Source/WebCore/platform/graphics/gpu/GPUBindGroupBinding.h:33
> +#include "GPUTexture.h"
> +
> +#include <wtf/Variant.h>

No blank line.

> Source/WebCore/platform/graphics/gpu/GPUBindGroupDescriptor.h:33
> +#include "GPUBindGroupLayout.h"
> +
> +#include <wtf/Vector.h>

No blank line. Should probably also include Ref.h