[webkit-reviews] review granted: [Bug 192824] [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element : [Attachment 358654] Patch and layout tests

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Daniel Bates
<dbates at webkit.org>'s request for review:
Bug 192824: [iOS] Keyups for non-modifier keys identified as "Dead" when not
focused in a content-editable element
https://bugs.webkit.org/show_bug.cgi?id=192824

Attachment 358654: Patch and layout tests

https://bugs.webkit.org/attachment.cgi?id=358654&action=review




--- Comment #6 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 358654
  --> https://bugs.webkit.org/attachment.cgi?id=358654
Patch and layout tests

View in context: https://bugs.webkit.org/attachment.cgi?id=358654&action=review

> Source/WebKit/ChangeLog:33
> +	   an intercepted UIEvents for app key commands.

Nit - s/an//

> LayoutTests/fast/events/ios/keypress-keys-in-non-editable-element.html:53
> +// FIXME: Test that keypress is not dispatch for "insert" once
<rdar://problem/47128940> is fixed.

Nit - …is not dispatched…