[webkit-reviews] review granted: [Bug 193294] REGRESSION (r237658): Tap highlight limits break legitimate with button sizes : [Attachment 358727] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted zalan
<zalan at apple.com>'s request for review:
Bug 193294: REGRESSION (r237658): Tap highlight limits break legitimate with
button sizes
https://bugs.webkit.org/show_bug.cgi?id=193294

Attachment 358727: Patch

https://bugs.webkit.org/attachment.cgi?id=358727&action=review




--- Comment #4 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 358727
  --> https://bugs.webkit.org/attachment.cgi?id=358727
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=358727&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.h:245
> +	   BOOL useHeuristicToDecideToPaint { false };

nodeHasBuiltInClickHandling?

> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:728
> +	   send(Messages::WebPageProxy::DidGetTapHighlightGeometries(requestID,
highlightColor, quads, roundedIntSize(borderRadii.topLeft()),
roundedIntSize(borderRadii.topRight()),
roundedIntSize(borderRadii.bottomLeft()),
roundedIntSize(borderRadii.bottomRight()), !is<HTMLInputElement>(node)));

Need to ensure that <button> and <label> work too. Maybe use
willRespondToMouseClickEvents().