[webkit-reviews] review requested: [Bug 192977] [GStreamer] Add sharedBuffer utility to GstMappedBuffer, and a testsuite : [Attachment 358691] Patch

[bugzilla-daemon at webkit.org]

Charlie Turner <cturner at igalia.com> has asked  for review:
Bug 192977: [GStreamer] Add sharedBuffer utility to GstMappedBuffer, and a
testsuite
https://bugs.webkit.org/show_bug.cgi?id=192977

Attachment 358691: Patch

https://bugs.webkit.org/attachment.cgi?id=358691&action=review




--- Comment #9 from Charlie Turner <cturner at igalia.com> ---
Created attachment 358691

  --> https://bugs.webkit.org/attachment.cgi?id=358691&action=review

Patch

Try again with SharedBuffer(GstMappedBuffer) overload. The only problem here is
that, to break the cyclic dependency on SharedBuffer and GstMappedBuffer,
SharedBuffer is declared as opaque in GStreamerCommon.h, so if you don't
include both GStreamerCommon.h *and* SharedBuffer.h in the usage code, then you
will get errors