[webkit-reviews] review granted: [Bug 177676] Web Inspector: Styles: Undo reverts all changes at once : [Attachment 358553] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 8 18:33:04 PST 2019


Devin Rousso <drousso at apple.com> has granted Nikita Vasilyev
<nvasilyev at apple.com>'s request for review:
Bug 177676: Web Inspector: Styles: Undo reverts all changes at once
https://bugs.webkit.org/show_bug.cgi?id=177676

Attachment 358553: Patch

https://bugs.webkit.org/attachment.cgi?id=358553&action=review




--- Comment #4 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 358553
  --> https://bugs.webkit.org/attachment.cgi?id=358553
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=358553&action=review

r=me, wow I didn't realize how much I wanted this till I tried using it 😅

> Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js:375
> +    spreadsheetTextFieldDidBlur(textField, event, hasChanged)

This is already implicitly past tense given the function name.	I think
`changed` is fine enough (it's also past tense).


More information about the webkit-reviews mailing list