[webkit-reviews] review granted: [Bug 193243] Stop using NetworkProcess::singleton in NetworkCache code : [Attachment 358609] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 193243: Stop using NetworkProcess::singleton in NetworkCache code
https://bugs.webkit.org/show_bug.cgi?id=193243

Attachment 358609: Patch

https://bugs.webkit.org/attachment.cgi?id=358609&action=review




--- Comment #3 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 358609
  --> https://bugs.webkit.org/attachment.cgi?id=358609
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=358609&action=review

> Source/WebKit/ChangeLog:4
> +	   https://bugs.webkit.org/show_bug.cgi?id=193243

Missing radar...

> Source/WebKit/NetworkProcess/cache/NetworkCache.h:166
> +    Ref<NetworkProcess> m_networkProcess;

This means that the NetworkCache will keep the NetworkProcess alive. Is that
the right ownership model? (I'm not disagreeing, just want to be sure that's
correct).

Otherwise we could make this a WeakPtr.

However, since it was a singleton before, I assume the expectation is we never
have a cache without a process (and vice versa).