[webkit-reviews] review granted: [Bug 193247] [WebGPU] Update createRenderPipeline for WebGPUPipelineLayout : [Attachment 358618] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 8 12:05:57 PST 2019


Dean Jackson <dino at apple.com> has granted Justin Fan <justin_fan at apple.com>'s
request for review:
Bug 193247: [WebGPU] Update createRenderPipeline for WebGPUPipelineLayout
https://bugs.webkit.org/show_bug.cgi?id=193247

Attachment 358618: Patch

https://bugs.webkit.org/attachment.cgi?id=358618&action=review




--- Comment #4 from Dean Jackson <dino at apple.com> ---
Comment on attachment 358618
  --> https://bugs.webkit.org/attachment.cgi?id=358618
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=358618&action=review

> Source/WebCore/platform/graphics/gpu/GPURenderPipelineDescriptor.h:47
> +    // Needed, as aggregate initialization of derived structs is not
supported until C++17.

I don't think we need this comment.


More information about the webkit-reviews mailing list